Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deb rpm: fix v4 migration with restarting service (master) #702

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Oct 30, 2024

No description provided.

Before:

* if td-agent.service exist and td-agent is active,
  stop td-agent and force v4 migration with restart process
  in postinst configure phase.

After:

* only execute v4 migration with restart process
  still v4 migration phase in postinst configure phase.

It might be a bug for v5.x

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Before:

* if td-agent.service is enabled mark enabled state
* if td-agent.service is active, but fluentd user does not exist,
  stop td-agent and create fluentd user. To make it enabled,
  restart service later.

After:

* only execute v4 migration with restart process
  when v4 migration phase is executed.

It might be a bug for v5.x

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys
Copy link
Contributor Author

kenhys commented Oct 30, 2024

#694

re-target from feature-nodowntime branch to master.

@kenhys kenhys marked this pull request as ready for review October 30, 2024 08:30
@kenhys kenhys changed the title deb rpm: fix v4 migration with restarting service deb rpm: fix v4 migration with restarting service (master) Oct 30, 2024
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kenhys kenhys merged commit c0dde15 into fluent:master Oct 31, 2024
99 checks passed
@kenhys kenhys deleted the fix-v4-migration-master branch October 31, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants