Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install transitional package #709

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Oct 31, 2024

Usually, transitional package (td-agent) will be installed when upgrading from v4. so it should be installed at the same time 
to test in practical use case.

Usually, transitional package (td-agent) will be installed
when upgrading from v4. so it should be installed at the same time.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thansk!
Note: It does not change the test behavior, but we should install the transitional package for the tests.

@daipom daipom merged commit 199eb21 into fluent:master Nov 1, 2024
93 of 105 checks passed
@kenhys kenhys deleted the fix-install-transitional branch November 1, 2024 01:23
kenhys added a commit that referenced this pull request Nov 11, 2024
Usually, transitional package (td-agent) will be installed when
upgrading from v4. so it should be installed at the same time 
to test in practical use case.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
daipom pushed a commit that referenced this pull request Nov 11, 2024
Usually, transitional package (td-agent) will be installed when
upgrading from v4. so it should be installed at the same time  to test
in practical use case.

ref. #709
 #711

---------

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants