- 
                Notifications
    
You must be signed in to change notification settings  - Fork 135
 
1.0: Add metrics plugin descriptions #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
01fc633    to
    b7a5dba      
    Compare
  
    Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
b7a5dba    to
    f57d9aa      
    Compare
  
    | 
           This PR should be merged into 1.0 after Fluentd v1.14 is shipped.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, from user point of view, it needs more explanation "how to".
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| 
           merged ㊗️  | 
    
| 
           Hooray! 🎉  | 
    
Add documentations for metrics plugin.
Mainly for fluent/fluentd#3479, fluent/fluentd#3473, and fluent/fluentd#3440
Signed-off-by: Hiroshi Hatake hatake@calyptia.com