Skip to content

Conversation

@cosmo0920
Copy link
Contributor

Add documentations for metrics plugin.

Mainly for fluent/fluentd#3479, fluent/fluentd#3473, and fluent/fluentd#3440

Signed-off-by: Hiroshi Hatake hatake@calyptia.com

@cosmo0920 cosmo0920 requested review from ashie and kenhys August 2, 2021 07:15
@cosmo0920 cosmo0920 self-assigned this Aug 2, 2021
@cosmo0920 cosmo0920 force-pushed the 1.0-metrics-plugin branch from 01fc633 to b7a5dba Compare August 2, 2021 07:16
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
@cosmo0920 cosmo0920 force-pushed the 1.0-metrics-plugin branch from b7a5dba to f57d9aa Compare August 2, 2021 07:47
@cosmo0920
Copy link
Contributor Author

cosmo0920 commented Aug 2, 2021

This PR should be merged into 1.0 after Fluentd v1.14 is shipped.

Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, from user point of view, it needs more explanation "how to".

Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenhys kenhys added this to the v1.14 milestone Aug 10, 2021
@kenhys kenhys merged commit ebba683 into fluent:1.0 Aug 30, 2021
@kenhys
Copy link
Contributor

kenhys commented Aug 30, 2021

merged ㊗️

@cosmo0920 cosmo0920 deleted the 1.0-metrics-plugin branch August 30, 2021 01:01
@cosmo0920
Copy link
Contributor Author

Hooray! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants