Change method name to proper name

Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
fluent · Jul 26, 2019 · 134070d · 134070d
1 parent 8940b4d
commit 134070d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lib/fluent/plugin/out_forward.rb b/lib/fluent/plugin/out_forward.rb
@@ -422,7 +422,7 @@ def ack_reader
                         end
 
       while thread_current_running?
-        @ack_handler.ack_reader(select_interval) do |chunk_id, node, sock, result|
+        @ack_handler.collect_response(select_interval) do |chunk_id, node, sock, result|
           @connection_manager.close(sock)
 
           case result

diff --git a/lib/fluent/plugin/out_forward/ack_handler.rb b/lib/fluent/plugin/out_forward/ack_handler.rb
@@ -37,7 +37,7 @@ def initialize(timeout, log:, read_length:)
         @unpacker = Fluent::Engine.msgpack_unpacker
       end
 
-      def ack_reader(select_interval)
+      def collect_response(select_interval)
         now = Fluent::Clock.now
         sockets = []
         results = []

diff --git a/test/plugin/out_forward/test_ack_handler.rb b/test/plugin/out_forward/test_ack_handler.rb
@@ -26,7 +26,7 @@ class AckHandlerTest < Test::Unit::TestCase
       ack.enqueue(r)
 
       a1 = a2 = a3 = a4 = nil
-      ack_handler.ack_reader(1) do |cid, n, s, ret|
+      ack_handler.collect_response(1) do |cid, n, s, ret|
         # This block is rescued by ack_handler so it needs to invoke assetion outside of this block
         a1 = cid; a2 = n; a3 = s; a4 = ret
       end
@@ -55,7 +55,7 @@ class AckHandlerTest < Test::Unit::TestCase
       ack.enqueue(r)
 
       a1 = a2 = a3 = a4 = nil
-      ack_handler.ack_handler(1) do |cid, n, s, ret|
+      ack_handler.collect_response(1) do |cid, n, s, ret|
         # This block is rescued by ack_handler so it needs to invoke assetion outside of this block
         a1 = cid; a2 = n; a3 = s; a4 = ret
       end
@@ -84,7 +84,7 @@ class AckHandlerTest < Test::Unit::TestCase
       ack.enqueue(r)
 
       a1 = a2 = a3 = a4 = nil
-      ack_handler.ack_handler(1) do |cid, n, s, ret|
+      ack_handler.collect_response(1) do |cid, n, s, ret|
         # This block is rescued by ack_handler so it needs to invoke assetion outside of this block
         a1 = cid; a2 = n; a3 = s; a4 = ret
       end