Skip to content

Commit

Permalink
Merge pull request #4331 from Garfield96/buffer-improve-logging
Browse files Browse the repository at this point in the history
buffer: Avoid calling dump_unique_id_hex if log level is not trace
  • Loading branch information
ashie authored Jan 24, 2024
2 parents 0893c39 + 4e2129a commit 175d866
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/fluent/plugin/buffer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ def takeback_chunk(chunk_id)
chunk = @dequeued.delete(chunk_id)
return false unless chunk # already purged by other thread
@queue.unshift(chunk)
log.trace "chunk taken back", instance: self.object_id, chunk_id: dump_unique_id_hex(chunk_id), metadata: chunk.metadata
log.on_trace { log.trace "chunk taken back", instance: self.object_id, chunk_id: dump_unique_id_hex(chunk_id), metadata: chunk.metadata }
@queued_num[chunk.metadata] += 1 # BUG if nil
@dequeued_num[chunk.metadata] -= 1
end
Expand Down Expand Up @@ -610,7 +610,7 @@ def purge_chunk(chunk_id)
@queued_num.delete(metadata)
@dequeued_num.delete(metadata)
end
log.trace "chunk purged", instance: self.object_id, chunk_id: dump_unique_id_hex(chunk_id), metadata: metadata
log.on_trace { log.trace "chunk purged", instance: self.object_id, chunk_id: dump_unique_id_hex(chunk_id), metadata: metadata }
end

nil
Expand Down

0 comments on commit 175d866

Please sign in to comment.