Fix shutdown sequence to wait force_flush #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loop: it does force_flush
* this feature makes it possible to control execute shutdown sequence per kind of plugins * to make it sure to shutdown input plugins before output plugins to stop emit events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are to wait
#force_flushof output plugins.#before_shutdowndoes#force_flushof output plugins, but it may emit events to other plugins. We should wait completion of all plugins before proceeding#shutdown.This change also includes blocker callback per kinds of plugins for each shutdown sequence steps.
This feature makes it sure to call shutdown calls of input plugins before output plugins.