Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate out_file to v0.14 API #1159

Closed
wants to merge 20 commits into from
Closed

Migrate out_file to v0.14 API #1159

wants to merge 20 commits into from

Conversation

okkez
Copy link
Contributor

@okkez okkez commented Aug 11, 2016 •
edited
Loading

TODO

  • Add test using sub sections (parse, inject, buffer)

@okkez okkez mentioned this pull request Aug 11, 2016
Closed
@okkez okkez changed the title WIP: Migrate out_file to v0.14 API Migrate out_file to v0.14 API Aug 12, 2016
@tagomoris tagomoris self-assigned this Aug 18, 2016
@repeatedly
Copy link
Member

Any progress on this patch?

@tagomoris
Copy link
Member

I'm writing an internal feature for parser/formatter/others to provide TimeParser/TimeFormatter & timezone configurations.
This change will be updated after that code.

@tagomoris tagomoris added pending To be done in the future and removed pending To be done in the future labels Sep 5, 2016
@tagomoris
Copy link
Member

I added the feature to handle TimeParser/TimeFormatter in parser/formatter plugins & inject/extract plugin helpers.
@okkez Could you update this patch on those?

@okkez
Copy link
Contributor Author

okkez commented Sep 7, 2016

OK, I will work for this after RubyKaigi2016.
Maybe 9/13 or later 🙇

@tagomoris tagomoris removed their assignment Sep 13, 2016
@tagomoris tagomoris added the moreinfo Missing version, need reproducible steps, need to investigate more label Sep 13, 2016
@okkez
Use Fluent::TimeFormatter to generate time based path
68afb25
@okkez
Require <inject> section
0fed1a0 
Because we cannot retrieve default value under <inject> section such as
`localtime`.

This change breaks backward compatibility.
@okkez
Copy link
Contributor Author

okkez commented Sep 14, 2016

@tagomoris I've pushed changes use new TimeFormatter.
Could you check latest 3 commits?

@tagomoris
Copy link
Member

@formatter.time_formatter_create in output plugin code looks bad :P
I suppose we need parameters for plugins to control timezones...

@tagomoris tagomoris self-assigned this Sep 14, 2016
@tagomoris tagomoris added pending To be done in the future and removed moreinfo Missing version, need reproducible steps, need to investigate more labels Sep 14, 2016
@tagomoris
Copy link
Member

Mmm. I'll take this task, because there are some difficult points to be considered...

@tagomoris tagomoris removed the pending To be done in the future label Sep 28, 2016
@tagomoris tagomoris mentioned this pull request Oct 4, 2016
Merged
@tagomoris
Copy link
Member

I re-created the change as #1257. Thank you to show me problems and basic form to be done.

@tagomoris tagomoris closed this Oct 4, 2016
@okkez okkez deleted the migrate-v0.14-api-out_file branch October 24, 2016 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tagomoris tagomoris

Labels
v0.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@okkez @repeatedly @tagomoris