Fix to prevent overwriting reserved placeholder keys such as tag #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -194,6 +194,7 @@ def preprocess_map(value, force_stringify = false) | |||
|
|
|||
| def prepare_placeholders(placeholder_values) | |||
| placeholders = {} | |||
| reserved_keys = Set.new(placeholder_values.keys) | |||
There was a problem hiding this comment.
Why is this Set needed?
Does placeholder_values.include?(k) have a problem?
There was a problem hiding this comment.
No problem, but for readability.
There was a problem hiding this comment.
Creating Set needs much resources.
I think plugin should keep lower resources.
… `enable_ruby false`
sonots
force-pushed
the
prevent_overwriting_reserved_placeholders
branch
from
8885773
to
28470d0
Compare
repeatedly
added a commit
that referenced
this pull request
Sep 5, 2016
…ceholders Fix to prevent overwriting reserved placeholder keys such as tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when same keys exist in record. The bug appeared only with on
enable_ruby falseSame thing with sonots/fluent-plugin-record-reformer#42