Plugin development enhancement #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repeatedly
reviewed
Oct 5, 2016
| @@ -598,6 +738,13 @@ def metadata(tag, time, record) | |||
| end | |||
| end | |||
|
|
|||
| def metadata_for_test(tag, time, record) | |||
| raise "BUG: #test_metadata is available only when no actual metadata exists" unless @buffer.metadata_list.empty? | |||
tagomoris
force-pushed
the
plugin-development-enhancement
branch
from
9baae94
to
01dd5c5
Compare
Logged errors are very hard to find for plugin authors, especially in tests. Errors will occur very easily (e.g., scripting bug). Normal plugin development should not use retries or secondary plugins. So there's no reason to execute rescue&retry in plguins.
tagomoris
force-pushed
the
plugin-development-enhancement
branch
from
1872484
to
7b89fb5
Compare
|
@repeatedly Rebased on master, and pushed a commit to update comment. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes some small changes to enhance plugin development:
extract_placeholders, without adding metadata into@buffer.metadata_listThis change is based on #1255.