Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store regexp options properly #1326

Merged
merged 1 commit into from
Nov 28, 2016
Merged

Store regexp options properly #1326

merged 1 commit into from
Nov 28, 2016

Conversation

okkez
Copy link
Contributor

@okkez okkez commented Nov 25, 2016

No description provided.

@okkez
Copy link
Contributor Author

okkez commented Nov 25, 2016

With Fluentd v0.14.6, fluent-plugin-grok-parser's test passed.
But with Fluentd v0.14.9 , fluent-plugin-grok-parser's test failed.

I noticed that Fluent::Compat::TextParser::RegexpParser#configure does not copy Regexp#options.

@tagomoris
Copy link
Member

LGTM

@tagomoris tagomoris merged commit d4313ec into fluent:master Nov 28, 2016
@okkez okkez deleted the store-regexp-options branch January 30, 2017 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@okkez @tagomoris