Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix not to check tag and variable placeholders when configured as secondary #1338

Merged

Conversation

tagomoris
Copy link
Member

@tagomoris tagomoris commented Nov 30, 2016

out_file has been used as plugin to dump data in secondary for a long time, and
that configuration looses consistency about chunk keys (even in v0.12).
But increment placeholder of out_file can create another file name (by just numbering) for such cases.

This change makes v0.14 to work with such configuration...

This fixes #1330.

…ondary

out_file has been used as plugin to dump data in secondary for a long time, and
that configuration looses consistency about chunk keys (even in v0.12).
But increment placeholder of out_file can create another file name (by just numbering) for such cases.

This change makes v0.14 to work with such configuration...
@tagomoris tagomoris added bug Something isn't working v0.14 labels Nov 30, 2016
@tagomoris
Copy link
Member Author

@repeatedly could you review this change?

@repeatedly
Copy link
Member

LGTM.

Further improvement, how about warning message like "For secondary, using secondary_file instead of file is recommended"?

@tagomoris
Copy link
Member Author

It's not bad but a bit troublesome to show that message only when primary plugin is NOT out_file plugin.

@tagomoris tagomoris merged commit 63eb1f2 into master Dec 6, 2016
@tagomoris tagomoris deleted the fix-to-skip-check-for-placeholders-as-secondary-out_file branch December 6, 2016 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v0.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With <secondary> and the path parameter, fluentd refuse to start
2 participants