fix to raise error if injected hostname_key is also specified in buffer chunk key #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@repeatedly could you review this? |
repeatedly
reviewed
Dec 8, 2016
| # don't have any side effect in chunking of output plugin. | ||
| if self.buffer_config.chunk_keys.include?(@_inject_hostname_key) | ||
| log.error "Use filters to inject hostname to use it in buffer chunking." | ||
| raise Fluent::ConfigError, "the key specified in 'hostname_key' cannot be used in buffering chunk key." |
There was a problem hiding this comment.
the key specified in 'hostname_key' of <inject> is better.
There was a problem hiding this comment.
Hmm, the key specified by 'hostname_key' in <inject> sounds correct.
|
Others LGTM |
tagomoris
force-pushed
the
fix-chunking-with-inject-result
branch
from
41452d4
to
ffdb371
Compare
|
Pushed the fixed commit. |
…er chunk key
Inject plugin helper does record.dup, so that Output plugin code cannot find any
side effect of inject plugin helper. It means output cannnot do chunking with injected values.
On the other hand, there is just few good use cases about chunking with injected hostname.
* chunking hostname (just after injected) is to route events with hostname... and hostname is unique on a host
* just one good use-case, to extract hostname into ${hostname} in configured values
* but it can be done by ruby code eval
tagomoris
force-pushed
the
fix-chunking-with-inject-result
branch
from
ffdb371
to
c6d29cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inject plugin helper does record.dup, so that Output plugin code cannot find any
side effect of inject plugin helper. It means output cannnot do chunking with injected values.
On the other hand, there is just few good use cases about chunking with injected hostname.
This fixes #1353.