Clock api for incremental second unit counter #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@repeatedly could you review this change? |
Merged
repeatedly
reviewed
Jan 19, 2017
| c0 = Fluent::Clock.now | ||
| t0 = Time.now | ||
| t1 = t0 - 30 | ||
| assert_kind_of Time, t1 |
There was a problem hiding this comment.
This checks ruby spec, not fluentd code.
So it seems not needed.
There was a problem hiding this comment.
That's true, but it assures this test code uses Time argument.
Assertions are sometimes used for such usage.
| end | ||
|
|
||
| def self.freeze(dst = nil, &block) | ||
| return freeze_block(dst, &block) if block_given? |
There was a problem hiding this comment.
if block is enough but trivial
|
LGTM and add comments. |
|
Let me merge this right now... Windows CI is failing with known timing bug of test code (and it's already fixed in #1426) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are many code to use
Time.nowto control flush timing and event invoke timing.It's basically wrong, because time may move to future or past by time adjustment, or affected by leap seconds (and Timecop).
We can use
Process.clock_gettimeto avoid this problem, but it's a bit troublesome to specify clock type available. It's too much and too raw for almost core code and plugins. UsingProcess.clock_gettimeis also not controlled by test code.So, this change will introduce a new internal API to provide clock value, which can be controlled to be frozen for tests.