Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_monitor_agent: Start one HTTP server per worker on sequential port numbers #1493

Merged

Conversation

mururu
Copy link
Member

@mururu mururu commented Mar 8, 2017

MonitorAgentInput doesn't work on multi worker environment because workers
try to start servers with the same port.

@repeatedly
Copy link
Member

Good catch.
BTW, how about adding launch_server like option to enable/disable server launching?
It allows users can use in_monitor_agent to emit buffer parameters in multi-process environment without this error.

@mururu
Copy link
Member Author

mururu commented Mar 9, 2017

@repeatedly Sounds good, but there is an another idea (@tagomotis sugestted) that each worker launch a server on different port(port + worker_id) on multi worker environment.

<system>
  worker 4
<system>
<source>
  @type monitor_agent
  port 24220
</source>

Using this conf, workers launche servers with port number 24220, 24221, 24222 and 24223.

I think that it is better for us to be able to use same feature on single worker environment and multi worker environment if possible.
How about that?

@repeatedly
Copy link
Member

It is also good.

@mururu
Copy link
Member Author

mururu commented Mar 9, 2017

Thanks, I'll go with it.

@mururu mururu force-pushed the disable-in-monitor-agent-on-multi-workers branch 2 times, most recently from cc50c7e to b9c715d Compare March 9, 2017 07:41
@mururu mururu changed the title Make MonitorAgentInput#multi_workers_ready? return false in_monitor_agent: Start one HTTP server per worker on sequential port numbers Mar 9, 2017
@mururu
Copy link
Member Author

mururu commented Mar 9, 2017

Updated.

@mururu mururu force-pushed the disable-in-monitor-agent-on-multi-workers branch from b9c715d to dcee14f Compare March 9, 2017 08:09
@repeatedly repeatedly merged commit acab7f4 into fluent:master Mar 9, 2017
@repeatedly
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants