Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rfc5424 regex without priority #1600

Merged
merged 2 commits into from
Jun 21, 2017
Merged

Add rfc5424 regex without priority #1600

merged 2 commits into from
Jun 21, 2017

Conversation

cosmo0920
Copy link
Contributor

No description provided.

@mururu
Copy link
Member

mururu commented Jun 20, 2017

Should we also fix REGEXP_DETECT_RFC5424?

@cosmo0920
Copy link
Contributor Author

I have no idea for now.
In without priority case, should we detect with time_format and @rfc5424_time_format?

@repeatedly
Copy link
Member

repeatedly commented Jun 20, 2017 •
edited
Loading

I don't think so. REGEXP_DETECT_RFC5424 is mainly used for in_syslog and there is no use case for syslog based file log because syslog based file doesn't contain 2 formats.

@mururu
Copy link
Member

mururu commented Jun 20, 2017

I see.

@repeatedly repeatedly merged commit 317235d into fluent:master Jun 21, 2017
@repeatedly
Copy link
Member

Thanks!
@cosmo0920 Could you send same patch to v0.12 branch?

@cosmo0920
Copy link
Contributor Author

Sure. I'll do it. :)

@cosmo0920 cosmo0920 deleted the add-without-pri-rfc5424-regex branch June 21, 2017 03:02
@cosmo0920 cosmo0920 restored the add-without-pri-rfc5424-regex branch June 21, 2017 05:39
@cosmo0920 cosmo0920 deleted the add-without-pri-rfc5424-regex branch June 21, 2017 05:39
@cosmo0920 cosmo0920 mentioned this pull request Jun 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cosmo0920 @mururu @repeatedly