Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command: Show fluentd version for debug purpose #1839

Merged
merged 2 commits into from
Feb 2, 2018

Conversation

repeatedly
Copy link
Member

No description provided.

@repeatedly repeatedly self-assigned this Jan 31, 2018
@repeatedly repeatedly added v1 enhancement Feature request or improve operations labels Jan 31, 2018
if command
if command == '--version'
puts "#{File.basename($PROGRAM_NAME)} #{Fluent::VERSION}"
exit 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to return 0.

@mururu
Copy link
Member

mururu commented Feb 1, 2018

Other than the return value, looks good.

@repeatedly repeatedly merged commit 24fd147 into master Feb 2, 2018
@repeatedly
Copy link
Member Author

Applied reviews. Merged.

@repeatedly repeatedly deleted the commands-show-version branch February 2, 2018 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants