in_http: Fix "ignored parser options" problem on bulk insertion #2055
+18
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What used to happen is that options in the <parser> section get ignored when we send events as a JSON array. This occurs because parser plugins are designed to handle a single hash value and do not generallly handle an array input well. Until now, we have tried to solve this issue by emulating the semantics of parser plugins in Fluent::Plugin::HttpInput (see 1afbfb1, 39f3a0d and f560017). However, this approach turned out to be error prone and rather tedious. This patch takes a different approach: - Whenever @parser is available, reuse @parser.convert_values() by manually applying it to each record in an input array. - Otherwise, fall back to the current logic. ... and should solve this class of issues. Signed-off-by: Fujimoto Seiji <fujimoto@clear-code.com>
fujimotos
force-pushed
the
sf/in-http-parser
branch
from
2efb1d5
to
2e5f963
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the bug reported by #2035 (and other related issues as well).
Problem
What used to happen is that options in the
<parser>section get ignoredwhen we send events as a JSON array. This occurs because parser plugins
are designed to handle a single hash value and do not generallly handle
an array input well.
Until now, we have tried to solve this issue by emulating the semantics
of parser plugins in Fluent::Plugin::HttpInput (see 1afbfb1, 39f3a0d
and f560017). However, this approach turned out to be error prone and
rather tedious.
More Generalized solution
This patch takes a different path:
@parseris available, reuse@parser.convert_values()bymanually applying it to each record in an input array.
The good part of this approach is that we do not need to duplicate the same
code in
in_httpandparser_jsonanymore, and it fixes this class of relatedissues.
Signed-off-by: Fujimoto Seiji fujimoto@clear-code.com