Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pretty print in config #2423

Merged
merged 3 commits into from
May 31, 2019

Conversation

ganmacs
Copy link
Member

@ganmacs ganmacs commented May 29, 2019

Which issue(s) this PR fixes:

Related #2422.
Please merge this patch after #2422 is merged.

What this PR does / why we need it:

In the current implementation, /api/config.json endpoint ignores ?debug=1 parameters even though /api/plugins.json endpoint respects the parameter.

Docs Changes:

not needed

Release Note:

not needed

@ganmacs ganmacs requested a review from repeatedly May 29, 2019 07:50
@repeatedly
Copy link
Member

Could you resolve the conflict?

Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
@ganmacs ganmacs force-pushed the enable-pretty-print-in-config branch from c280394 to bb6750f Compare May 31, 2019 02:14
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
@ganmacs ganmacs force-pushed the enable-pretty-print-in-config branch from bb6750f to 759be8c Compare May 31, 2019 02:16
@ganmacs
Copy link
Member Author

ganmacs commented May 31, 2019

resolved it :)

@repeatedly repeatedly merged commit 71f223f into fluent:master May 31, 2019
@repeatedly
Copy link
Member

Thanks!

@ganmacs ganmacs deleted the enable-pretty-print-in-config branch June 3, 2019 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants