-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format in_tail path with the specified timezone #2719
Conversation
It's reasonable for me to use |
Yes. |
Thank you for reply.
If there are any problems, please point them out. |
Sounds good. I've thought same thing. path_timezone is better. Could you follow the DCO https://github.com/fluent/fluentd/pull/2719/checks?check_run_id=341323383 ?(I think you know. it's just confirming) |
Sure, I'll squash commits and sign off at that time. |
5955c0d
to
ca129a9
Compare
Signed-off-by: tatsu-yam <anningoo24@gmail.com>
ca129a9
to
5bc0994
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! |
Which issue(s) this PR fixes:
None
What this PR does / why we need it:
If the file path which in_tail plugin reads includes strftime format, it is determined by system timezone.
I want to determine this path in the specified timezone for each tail plugin object.
For example, a fluentd process reads a UTC file path (
/path/to/data/test_utc/20191210_04.json
) and a JST file path (/path/to/data/test_jst/20191210_13.json
) in one conf.I wrote a simple path, but is it correct to use
Fluent::Timezone
class?Docs Changes:
None
Release Note:
None