Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine CI #4380

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Refine CI #4380

merged 2 commits into from
Jan 15, 2024

Conversation

ashie
Copy link
Member

@ashie ashie commented Jan 15, 2024

Which issue(s) this PR fixes:
N/A
See also: #4375 (comment)

What this PR does / why we need it:

Refine CI settings:

  • Unify CI settings for each platforms to one file
  • Don't run CI for Ruby head on each push/pull_request event
    • Because Ruby head is continually changed and not released yet, running CI one shot isn't so meaningful.
    • Instead run it regularly on every Sunday.
  • Add TESTOPT=-v to all platfroms
    • It's useful to investigate when a test is stalled.
  • Remove a hack for Ruby 3.0 on Windows
    • It seems no longer needed.

Docs Changes:
N/A

Release Note:
N/A

And remove tests for Ruby head. It will be moved to a separated file.

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
Signed-off-by: Takuro Ashie <ashie@clear-code.com>
@ashie ashie marked this pull request as ready for review January 15, 2024 07:50
@ashie ashie requested review from kenhys and daipom January 15, 2024 07:51
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit 0893c39 into master Jan 15, 2024
16 checks passed
@kenhys kenhys deleted the refine-ci branch January 15, 2024 08:29
@ashie
Copy link
Member Author

ashie commented Jan 16, 2024

Oops, I forgot to remove WIP from the title...

@daipom
Copy link
Contributor

daipom commented Mar 8, 2024

Oops, I forgot to remove WIP from the title...

Can I remove WIP from the title? Is there any reason you haven't removed it yet?

@ashie ashie changed the title WIP: Refine CI Refine CI Mar 10, 2024
@daipom
Copy link
Contributor

daipom commented Mar 11, 2024

Thanks!

daipom pushed a commit that referenced this pull request Mar 11, 2024
Refine CI settings:

* Unify CI settings for each platforms to one file
* Don't run CI for Ruby head on each push/pull_request event
    * Because Ruby head is continually changed and not released
      yet, running CI one shot isn't so meaningful.
    * Instead run it regularly on every Sunday.
* Add TESTOPT=-v to all platfroms
    * It's useful to investigate when a test is stalled.
* Remove a hack for Ruby 3.0 on Windows
    * It seems no longer needed.
daipom pushed a commit that referenced this pull request Mar 11, 2024
Refine CI settings:

* Unify CI settings for each platforms to one file
* Don't run CI for Ruby head on each push/pull_request event
    * Because Ruby head is continually changed and not released
      yet, running CI one shot isn't so meaningful.
    * Instead run it regularly on every Sunday.
* Add TESTOPT=-v to all platfroms
    * It's useful to investigate when a test is stalled.
* Remove a hack for Ruby 3.0 on Windows
    * It seems no longer needed.
daipom pushed a commit that referenced this pull request Mar 11, 2024
Refine CI settings:

* Unify CI settings for each platforms to one file
* Don't run CI for Ruby head on each push/pull_request event
    * Because Ruby head is continually changed and not released
      yet, running CI one shot isn't so meaningful.
    * Instead run it regularly on every Sunday.
* Add TESTOPT=-v to all platfroms
    * It's useful to investigate when a test is stalled.
* Remove a hack for Ruby 3.0 on Windows
    * It seems no longer needed.

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
ashie added a commit that referenced this pull request Mar 11, 2024
@ashie ashie added this to the v1.17.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants