Guard launching duplicated fluentd with same configuration #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenhys
force-pushed
the
guard-duplicated
branch
2 times, most recently
from
67bf078 to
9110af4
Compare
Before:
If you launch multiple Fluentd instance with same
configuration file, it causes a disaster with inconsistency
processed buffer or pos file.
After:
Detect fluentd service's main process and fetch FLUENT_CONF.
if configuration is same as spawned process, abort it.
It can block the following conditions are met:
* fluentd is launched via systemd (fluent-package)
configuration file is specified via FLUENT_CONF.
* manually try to launch fluentd with same configuration file as
fluentd user with -c option.
Thus running fluentd service and manually try to launch normal
user case can't be detected.
NOTE: Windows is out of scope in this PR.
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
force-pushed
the
guard-duplicated
branch
from
9110af4 to
ac5fb4d
Compare
|
Reconsider, it is not appropriate to introduce package specific fix to fluentd internals. 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes fluent/fluent-package-builder#611
What this PR does / why we need it:
This is just a PoC PR.
Before:
If you launch multiple Fluentd instance with same
configuration file, it causes a disaster with inconsistency
processed buffer or pos file.
After:
Detect fluentd service's main process and fetch FLUENT_CONF.
if configuration is same as spawned process, abort it.
It can block the following conditions are met:
Thus running fluentd service and manually try to launch normal
user case can't be detected.
NOTE: Windows is out of scope in this PR.
Docs Changes:
N/A
Release Note:
N/A