-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: yaml_parser: Handle $log_level element for special case #4482
Conversation
This is because `@log_level` is invalid for YAML. Instead, we should interpret $log_level as `@log_level` on YAML parser. Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Thanks! I will check this tomorrow! |
I confirmed that it works fine.
|
@Shingo-Nakayama Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Thanks! |
BTW, Which versions will this feature be enabled? 1.17.1 or 1.16.6? |
I will backport this to 1.16.6 if there is no objection. |
OK. I don't have any objections. Let's backport this to v1.16.6. |
Backport(v1.16): config: yaml_parser: Handle $log_level element for special case (#4482)
Which issue(s) this PR fixes:
Closes #4463.
What this PR does / why we need it:
This is because
@log_level
is invalid for YAML.Instead, we should interpret $log_level as
@log_level
on YAML parser.Docs Changes:
Needed. Will handle on it.fluent/fluentd-docs-gitbook#497
Release Note:
Same as title.