in_tail: Fix line skipping issue in receive_lines method #4530
Conversation
Before this patch, long lines could cause breakdowns in fluentd, potentially posing a vulnerability. With this patch, max_line_size will be integrated into the FIFO, enabling the system to skip lines exceeding the maximum size before executing receive_lines. Co-authored-by: yugeeklab <yugeeklab@gmail.com> Co-authored-by: moggaa <donionbs7@gmail.com> Signed-off-by: been.zino <been.zino@kakaocorp.com>
Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com> Signed-off-by: been.zino <been.zino@kakaocorp.com>
Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com> Signed-off-by: been.zino <been.zino@kakaocorp.com>
Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com> Signed-off-by: been.zino <been.zino@kakaocorp.com>
Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com> Signed-off-by: been.zino <been.zino@kakaocorp.com>
Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com> Signed-off-by: been.zino <been.zino@kakaocorp.com>
Co-authored-by: Daijiro Fukuda <fukuda@clear-code.com> Signed-off-by: been.zino <been.zino@kakaocorp.com>
Signed-off-by: been.zino <been.zino@kakaocorp.com>
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
|
@yugeeklab I have pushed the commits for #4491 (comment). |
There was a problem hiding this comment.
Basically it look good to me, thanks for your contribution!
I've added some nitpick comments about logging.
In addition, it would be happy if we can simplify FIFO#read_lines to make easy to read although I have no idea about it yet.
What do you think about these my comments? @daipom
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com> Co-authored-by: Takuro Ashie <ashie@clear-code.com>
Thanks for your comments! About the simplification, I have the same opinion. I'll think about it for a bit. |
daipom
changed the title
Which issue(s) this PR fixes:
Fixes #4494
recoverd from #4491
What this PR does / why we need it:
Before this patch, long lines could cause breakdowns in fluentd, potentially posing a vulnerability. With this patch, max_line_size will be integrated into the FIFO, enabling the system to skip lines exceeding the maximum size before executing receive_lines.
Docs Changes:
Release Note: