Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-generator: update gemspec to remove unnecessary files #4535

Merged

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Jun 20, 2024

Which issue(s) this PR fixes:
None.

What this PR does / why we need it:

Docs Changes:
Not needed.
(There is no change needed for https://docs.fluentd.org/plugin-development#generating-plugin-project-skeleton)

Release Note:
Not needed.

We should reflect recent gemspec moves.

`test_files` is not documented anymore:

* https://guides.rubygems.org/specification-reference

The template of Bundler 2.4.13 is as follows:

    spec.files = Dir.chdir(__dir__) do
      `git ls-files -z`.split("\x0").reject do |f|
        (File.expand_path(f) == __FILE__) ||
          f.start_with?(*%w[bin/ test/ spec/ features/ .git .circleci appveyor Gemfile])
      end
    end

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@ashie ashie merged commit d07d6ea into fluent:master Jul 7, 2024
15 of 16 checks passed
@daipom daipom added this to the v1.17.1 milestone Aug 15, 2024
@daipom daipom deleted the plugin-generator-update-template-gemspec branch August 15, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants