[PoC] Update/Reload without downtime #4654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it easier to re-use plugin shutdown process. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
commented
Oct 3, 2024
| start_new_supervisor | ||
|
|
||
| # TODO: 少なくとも worker を１つでも起動できるように戻さないと自身が死ななかった | ||
| scale_up |
There was a problem hiding this comment.
タイミングによっては、scale_up によってワーカーが起動してしまうかもしれない。
scale_up しなくても「古いプロセス(自分自身)を止める」ことができるようにしないと危ないだろう。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Yet another proof of concept for #4624
This PR depends on treasure-data/serverengine#149
Docs Changes:
Release Note: