Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_out_file: fix file open mode for binary file #4728

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Watson1978
Copy link
Contributor

Which issue(s) this PR fixes:
Fixes #4727

What this PR does / why we need it:
Fix the file open mode so that gz files can be read properly.

Docs Changes:

Release Note:

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
@Watson1978 Watson1978 added the CI Test/CI issues label Dec 7, 2024
@Watson1978 Watson1978 requested a review from daipom December 7, 2024 04:46
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks!

@kenhys kenhys merged commit 7868b5d into fluent:master Dec 9, 2024
14 of 16 checks passed
@daipom daipom added the backport to LTS We will backport this fix to the LTS branch label Dec 9, 2024
@daipom
Copy link
Contributor

daipom commented Dec 9, 2024

Excellent!

@Watson1978 Watson1978 deleted the fix-test_out_file branch December 9, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to LTS We will backport this fix to the LTS branch CI Test/CI issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: "can format/write data correctly" test fails withZlib::GzipFile::Error on Windows
3 participants