gemspec: fix io-event and io-stream version to avoid unstable behavior on Windows #5042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears io-event >= 1.11.0 are unstable on Windows (confirmed on 1.12.1 or lower). See fluent#5041. io-stream >= 0.8 needs io-event >= 1.12.0, so we need to fix io-stream version as well (confirmed on 0.10.0 or lower). See socketry/io-stream#8. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
daipom
force-pushed
the
gemspec-fix-io-event-version
branch
from
ec55047 to
2431693
Compare
daipom
changed the title
|
Looks like #5041 is resolved. It is unnatural |
Watson1978
approved these changes
Jul 30, 2025
daipom
added a commit
to daipom/fluentd
that referenced
this pull request
Sep 8, 2025
… behavior on Windows (fluent#5042)" This reverts commit 420e166. 85740ac should resolve the fundamental issue. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
daipom
added a commit
that referenced
this pull request
Sep 9, 2025
… behavior on Windows (#5042)" (#5078) **Which issue(s) this PR fixes**: * Related to #5041 **What this PR does / why we need it**: This reverts commit 420e166. 85740ac should resolve the fundamental issue. **Docs Changes**: Not needed. **Release Note**: CI fixes. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
It appears io-event >= 1.11.0 are unstable on Windows
(confirmed on 1.12.1 or lower).
See #5041.
io-stream >= 0.8 needs io-event >= 1.12.0, so we need to fix
io-stream version as well (confirmed on 0.10.0 or lower).
See socketry/io-stream#8.
Docs Changes:
Not needed.
Release Note:
The same as the title.