Skip to content

test_filter_record_transformer: pass a Time object to Timecop.freeze #5077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2025
Merged

test_filter_record_transformer: pass a Time object to Timecop.freeze #5077

merged 3 commits into from
Sep 8, 2025

Conversation

@Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Sep 8, 2025 •
edited by daipom
Loading

Which issue(s) this PR fixes:
Fixes #5041

What this PR does / why we need it:
I'm investigating #5041

When run the RecordTransformerFilterTest,
it handles incorrect timestamps.

Reproduce:

    @time = event_time('2010-05-04 03:02:01 UTC')
    Timecop.freeze(@time)

    logger = Logger.new(STDOUT)
    p logger.info("Test::RecordTransformerFilterTest setup")

Result:

I, [1272942121-01-01T00:00:00.000000 #12576]  INFO -- : Test::RecordTransformerFilterTest setup

We should pass Time object into Timecop.freeze

Docs Changes:
Not needed

Release Note:
CI fixes

@Watson1978 Watson1978 added the CI Test/CI issues label Sep 8, 2025
@Watson1978 Watson1978 requested review from daipom and kenhys September 8, 2025 07:01
@Watson1978 Watson1978 changed the title test_filter_record_transformer: pass a Time object Timecop.freeze test_filter_record_transformer: pass a Time object into Timecop.freeze Sep 8, 2025
@Watson1978 Watson1978 changed the title test_filter_record_transformer: pass a Time object into Timecop.freeze test_filter_record_transformer: pass a Time object to Timecop.freeze Sep 8, 2025
@Watson1978
test_filter_record_transformer: pass a Time object to Timecop.freeze
f9f74fd 
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
@daipom daipom added this to the v1.19.1 milestone Sep 8, 2025
daipom
daipom reviewed Sep 8, 2025
View reviewed changes
@Watson1978
Revert "test_filter_record_transformer: pass a Time object to Timecop…
4e17993 
….freeze"

This reverts commit f9f74fd.

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
@Watson1978
test_filter_record_transformer: pass a Time object to Timecop.freeze
95c2e17 
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
daipom
daipom approved these changes Sep 8, 2025
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daipom daipom merged commit 85740ac into fluent:master Sep 8, 2025
17 checks passed
@Watson1978 Watson1978 deleted the timecop-freeze branch September 8, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daipom daipom daipom approved these changes

@kenhys kenhys Awaiting requested review from kenhys

Assignees

No one assigned

Labels

CI Test/CI issues

Projects

None yet

Milestone

v1.19.1

Development

Successfully merging this pull request may close these issues.

CI for Ruby 3.2 and 3.3 on Windows are sometimes abnormally slow

2 participants

@Watson1978 @daipom