Skip to content

Conversation

@daipom
Copy link
Contributor

@daipom daipom commented Sep 10, 2025

Which issue(s) this PR fixes:

Fixes #5054

What this PR does / why we need it:
This PR will resolve CI error.

Docs Changes:
N/A

Release Note:
N/A

@daipom daipom added this to the v1.16.10 milestone Sep 10, 2025
@daipom daipom added the CI Test/CI issues label Sep 10, 2025
Watson1978
Watson1978 previously approved these changes Sep 11, 2025
@daipom
Copy link
Contributor Author

daipom commented Sep 11, 2025

This should fix ObjectSpaceInputTest, but it fails...

**Which issue(s) this PR fixes**:
Fixes fluent#5054

**What this PR does / why we need it**:
This PR will resolve CI error.

**Docs Changes**:
N/A

**Release Note**:
N/A

---------

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@Watson1978
Copy link
Contributor

On v1.16 branch, seems it still causes #5054 with test_in_object_space.rb and test_out_forward.rb combination.

$ bundle exec ruby -I"lib:test" -Eascii-8bit:ascii-8bit ~/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/rake-13.3.0/lib/rake/rake_test_loader.rb \
    "test/plugin/test_in_object_space.rb" "test/plugin/test_out_forward.rb" -v          
/home/watson/src/fluentd/lib/fluent/compat/parser.rb:28: warning: csv was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.
You can add csv to your Gemfile or gemspec to silence this warning.
Loaded suite /home/watson/.rbenv/versions/3.3.9/lib/ruby/gems/3.3.0/gems/rake-13.3.0/lib/rake/rake_test_loader
Started
ForwardOutputTest: 
  test: Create new connection per send_data:                                                                                                                                                                                                                            .: (0.232909)
  test: Node with security is thread-safe on multi threads:                                                                                                                                                                                                             .: (0.822002)

...(snip)...
  
ObjectSpaceInputTest: 
  test_configure:                                                                                                                                                                                                                                                       .: (0.003062)
  test_emit:                                                                                                                                                                                                                                                            F
=============================================================================================================================================================================================================================================================================================
Failure: test_emit(ObjectSpaceInputTest):
      assert{ emits.length > 0 }
              |     |      |
              |     |      false
              |     0
              []
/home/watson/src/fluentd/test/plugin/test_in_object_space.rb:62:in `test_emit'
     59:     d.run(expect_emits: 3)
     60: 
     61:     emits = d.events
  => 62:     assert{ emits.length > 0 }
     63: 
     64:     emits.each { |tag, time, record|
     65:       assert_equal d.instance.tag, tag
=============================================================================================================================================================================================================================================================================================
: (300.307336)

Finished in 342.326487655 seconds.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
62 tests, 136 assertions, 1 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications
98.3051% passed
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
0.18 tests/s, 0.40 assertions/s

@Watson1978
Copy link
Contributor

Seems the error is caused by

mock = flexmock($log)

On master branch, flexmock($log) was removed by #4896

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
@daipom
Copy link
Contributor Author

daipom commented Sep 11, 2025

Thanks for fixing it!

@daipom daipom merged commit c301faa into fluent:v1.16 Sep 11, 2025
21 checks passed
@daipom daipom deleted the barkport-pr5055 branch September 11, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Test/CI issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants