Enhancements to Windows service install/uninstall. #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mr-salty
commented
Mar 8, 2016
mr-salty
commented
- If --reg-winsvc-auto-start is specified when installing the service (--reg-winsvc i), set the service type to AUTO_START rather than DEMAND_START, and also start the service immediately.
- When uninstalling (--reg-winsvc u), attempt to stop the service if it is running. This is done unconditionally.
- Also allow --reg-winsvc-fluentdopt to be specified along with --reg-winsvc; previously the options would be ignored. The flag can still be specified alone to change the options (although a service restart is necessary).
If --reg-winsvc-auto-start is specified when installing the service (--reg-winsvc i), set the service type to AUTO_START rather than DEMAND_START, and also start the service immediately. When uninstalling (--reg-winsvc u), attempt to stop the service if it is running. This is done unconditionally. Also allow --reg-winsvc-fluentdopt to be specified along with --reg-winsvc; previously the options would be ignored. The flag can still be specified alone to change the options (although a service restart is necessary).
nurse
added a commit
that referenced
this pull request
Mar 15, 2016
Enhancements to Windows service install/uninstall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.