Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce to use router.emit #883

Merged
merged 1 commit into from
Apr 6, 2016
Merged

Enforce to use router.emit #883

merged 1 commit into from
Apr 6, 2016

Conversation

okkez
Copy link
Contributor

@okkez okkez commented Apr 6, 2016

No description provided.

@tagomoris
Copy link
Member

LGTM

@repeatedly repeatedly merged commit beebe98 into fluent:master Apr 6, 2016
@riywo
Copy link
Contributor

riywo commented Jun 12, 2016

In the code of v0.14.0, there is still Engine.emit_stream.
https://github.com/fluent/fluentd/blob/v0.14.0/lib/fluent/process.rb#L172

Because of this code, detach_process doesn't work for fluent-plugin-kinesis. I know using detach_process in output plugin is not a good idea, but could you provide a backward compatibility? If it is difficult, I'd like to try to get rid of this feature ASAP...

@tagomoris
Copy link
Member

It looks pretty large & complex patch to support router with detach_process feature.

  • introduce router (and log) from DetachProcessMixin to DetachProcessImpl
  • use introduced router in DetachProcessImpl

The biggest problem is that there are no tests about this feature. So it can't be fixed so quickly.
Please open another issue for this if it's serious for you.

@okkez okkez deleted the enforce-to-use-router-emit branch September 28, 2016 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v0.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@okkez @tagomoris @riywo @repeatedly