Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

modified Vector v4 equality check #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

modified Vector v4 equality check #35

wants to merge 1 commit into from

Conversation

adnanmuttaleb
Copy link

According to my understanding of hashing and equality, I tried to enhance the performance of equality checking by ensuring that __eq__ does not perform component based comparison only if vectors has the same hash values (if two hashes is different then the two vectors are definitely unequal). because if two vectors has same hash value then:

  •    either they equal 
    
  •    they are not equal `Vector(1, 0, -1)`  and  `Vector(1, -1, 0)` will have the same hash value of -2
    

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant