1.5 Fix for reordering #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Fluffy!
Really love your mod. I just tried to fix the reordering issue for AreaUnlocker and I succeeded.
The problem was caused by the ReorderableWidget.NewGroup function which would return -1 when the current event type is not repaint. And if you logged the value of reorderableGroup, you will find it is a lot of -1,0,-1,0
After assigning it to a static private variable and check it only when the event type is repaint, it solves the issue.
I didn't have the exact same environment with you, so I'm just changing the source file in this fork after tested it on my configuration. You may need to rebuild it and see whether everything works fine. (I don't have the ColourPicker project on my system afterall, on my system I have to remove the sln file, changing the project reference to reference dll, and ignore the emitted error for mod update command not found )
I'm using a lot of mods from you. Thank you so much for all your contributions!