horizontal UI cutoff #159
Labels
Comments
sineme
added a commit
to sineme/WorkTab
that referenced
this issue
Dec 28, 2022
fixes fluffy-mods#157, fluffy-mods#159 and fluffy-mods#164 The scroll area was using cachedSize for its output rectangle capping it at the screen width. As the "Work"-tab window is not as wide as the screen, ouput rectangle was too wide when there were many work types. To fix this the PawnTable was extended with the property methods void set_OutRect(this PawnTable, Rect) and Rect get_OutRect() 'fake adding' a new property that can be used to set and get the "Work"-tab window dimension instead of relying on the screen size. MainTabWindow_WorkTab.DoWindowContents calls set_OutRect with the window dimension PawnTable_PawnTableOnGUI.PawnTableOnGUI calls get_OutRect to clamp the output rectangle properly
sineme
added a commit
to sineme/WorkTab
that referenced
this issue
Dec 28, 2022
fixes fluffy-mods#157, fluffy-mods#159 and fluffy-mods#164 The scroll area was using cachedSize for its output rectangle capping it at the screen width. As the "Work"-tab window is not as wide as the screen, ouput rectangle was too wide when there were many work types. To fix this the PawnTable was extended with the property methods void set_OutRect(this PawnTable, Rect) and Rect get_OutRect() 'fake adding' a new property that can be used to set and get the "Work"-tab window dimension instead of relying on the screen size. MainTabWindow_WorkTab.DoWindowContents calls set_OutRect with the window dimension PawnTable_PawnTableOnGUI.PawnTableOnGUI calls get_OutRect to clamp the output rectangle properly I think ideally PawnTable.PawnTableOnGUI's parameter would be Rect window instead of Vector2 position in the future.
Kupie
added a commit
to Kupie/WorkTab
that referenced
this issue
Apr 15, 2024
* Update FavouriteManager.cs Fluffy.WorkTab.NoStoredFavourites was not translated * Default priority (+ tip) setting now transletable Update Keyed-English.xml * Fix horizontal scroll area fixes fluffy-mods#157, fluffy-mods#159 and fluffy-mods#164 The scroll area was using cachedSize for its output rectangle capping it at the screen width. As the "Work"-tab window is not as wide as the screen, ouput rectangle was too wide when there were many work types. To fix this the PawnTable was extended with the property methods void set_OutRect(this PawnTable, Rect) and Rect get_OutRect() 'fake adding' a new property that can be used to set and get the "Work"-tab window dimension instead of relying on the screen size. MainTabWindow_WorkTab.DoWindowContents calls set_OutRect with the window dimension PawnTable_PawnTableOnGUI.PawnTableOnGUI calls get_OutRect to clamp the output rectangle properly I think ideally PawnTable.PawnTableOnGUI's parameter would be Rect window instead of Vector2 position in the future. * Respect "Disable Scrollwheel" on Checkbox WorkTypes * Replace Job Icon Column with Job Text Column * Make Mod Setting for Job Text Column (Icon vs Text) * Localize Mod Setting for Job Text Column * Add Option to Highlight Current Active Work Cell * Fix: Priorities reset after save-load. PriorityManager class was relying on Scribe methods in ExposeData() for clearing out old priorities data. But ExposeData() is not called when a new game is started or a game is loaded which was saved without the mod active. So, new data was added to the old one. If a non-modded save was loaded twice, pawn priorities lists were doubled, with the latest list being active. When the game was subsequently saved and loaded, all data was saved, but only the oldest copy of priorities was restored. Other copies yielded an error: Exception in LookDictionary(label=Priorities): System.InvalidOperationException: Tried to add different values for the same key. Attempts to load priorities data of non-existent pawns, inherited from other games, resulted in a probably harmless error: Could not resolve reference to object with loadID Thing_Human# Now, all static members of PriorityManager are initialized by constructor. * Removed unused project DynamicPawnTable. * Fix warning: DrawUtilities probably needs a StaticConstructorOnStartup attribute Fix warning in the game's log: Type DrawUtilities probably needs a StaticConstructorOnStartup attribute, because it has a field activeHighlightBox of type Texture2D. All assets must be loaded in the main thread. * Fix: Naming rule violation. * Fix: active job frame is too bright. * Fix wording in tooltips: increase/increment/decrease/decrement priorities => raise/lower * Enable HighlightCurrentJobCell by default. Also, change names and labels for being consistent: ActiveWorkCells => CurrentJobCell. Minor clean-up. * Fix: Numeric settings are reset after restarting the game. * Fix the last fix: Numeric settings are hard to edit. --------- Co-authored-by: angelolocritani <67960642+angelolocritani@users.noreply.github.com> Co-authored-by: Sineme <sineme@users.noreply.github.com> Co-authored-by: maarxx <chris.lewark@gmail.com> Co-authored-by: Doomster14 <146005125+Doomster14@users.noreply.github.com>
JiaRG
pushed a commit
to JiaRG/WorkTab
that referenced
this issue
Jul 7, 2024
fixes fluffy-mods#157, fluffy-mods#159 and fluffy-mods#164 The scroll area was using cachedSize for its output rectangle capping it at the screen width. As the "Work"-tab window is not as wide as the screen, ouput rectangle was too wide when there were many work types. To fix this the PawnTable was extended with the property methods void set_OutRect(this PawnTable, Rect) and Rect get_OutRect() 'fake adding' a new property that can be used to set and get the "Work"-tab window dimension instead of relying on the screen size. MainTabWindow_WorkTab.DoWindowContents calls set_OutRect with the window dimension PawnTable_PawnTableOnGUI.PawnTableOnGUI calls get_OutRect to clamp the output rectangle properly I think ideally PawnTable.PawnTableOnGUI's parameter would be Rect window instead of Vector2 position in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reported by: AerosAtar
Description:
Is there a way to increase the left/right scroll area? I end up with too many jobs when using this with Complex Jobs and the last job is partially cut off, with the favourite/copy/paste buttons entirely unavailable.
The text was updated successfully, but these errors were encountered: