Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support injecting file prefetcher sidecar to app pods #4490

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat: support injecting file prefetcher sidecar to app pods #4490

wants to merge 7 commits into from

Conversation

TrafalgarZZZ
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@TrafalgarZZZ
Add fileprefetcher webhook plugin
ab6b6fe 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@fluid-e2e-bot fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from trafalgarzzz by writing /assign @trafalgarzzz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Feb 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@TrafalgarZZZ
Fail fast when no valid file prefetcher image is set
5281d8a 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
Fix extra env code logic
b702591 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
Add fluid file prefetcher Dockerfile
477e968 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 10, 2025
View reviewed changes
tools/file-prefetcher/Dockerfile Fixed Show fixed Hide fixed
tools/file-prefetcher/Dockerfile Fixed Show fixed Hide fixed
@TrafalgarZZZ
Add license header
1ae4ac8 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
Use COPY instead of ADD for copying local resources
9e0d72c 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@TrafalgarZZZ
Enable FilePrefetcher by default
ba0a1f2 
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
4 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@TrafalgarZZZ TrafalgarZZZ marked this pull request as ready for review February 10, 2025 12:57
@TrafalgarZZZ
Copy link
Member Author

/test fluid-e2e

@TrafalgarZZZ
Copy link
Member Author

/retest

1 similar comment
@TrafalgarZZZ
Copy link
Member Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheyang cheyang cheyang left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TrafalgarZZZ @cheyang