Skip to content

This PR is to add comments to TestCheckRuntimeHealthy in pkg/ddc/alluxio/health_check_test.go. #4969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jjqqcj
Copy link
Contributor

@jjqqcj jjqqcj commented May 30, 2025

Ⅰ. Describe what this PR does
Add comments to TestCheckRuntimeHealthy in pkg/ddc/alluxio/health_check_test.go

Ⅱ. Does this pull request fix one issue?
fixes #4927

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

fluid-e2e-bot bot commented May 30, 2025

Hi @jjqqcj. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jjqqcj jjqqcj force-pushed the add-comments-to-init-methods branch from 89fe306 to 4855213 Compare June 2, 2025 05:10
Copy link

sonarqubecloud bot commented Jun 2, 2025

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

fluid-e2e-bot bot commented Jun 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 3357288 into fluid-cloudnative:master Jun 27, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comments to TestCheckRuntimeHealthy in pkg/ddc/alluxio/health_check_test.go
2 participants