Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to search input #153

Closed
Arraxx opened this issue Feb 23, 2020 · 2 comments · Fixed by #263
Closed

Add button to search input #153

Arraxx opened this issue Feb 23, 2020 · 2 comments · Fixed by #263
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Arraxx
Copy link

Arraxx commented Feb 23, 2020

We can add a search icon button for search as it will be easy for the user to search desired items

screenshot:

Screenshot from 2020-02-23 14-17-52

additional context:

i would like to take this issue,

@Arraxx
Copy link
Author

Arraxx commented Feb 24, 2020

@jobara

@jhung
Copy link
Member

jhung commented Feb 27, 2020

Thanks @coderbabu10. Can you create a branch in your fork with these changes so I can see what you are suggesting?

In your solution can you keep in mind web accessibility practices such as keyboard accessibility, colour contrast (you can use this tool to help), and alt text for a functional image. This guide may be useful too "Quick-and-Dirty Website Accessibility Tests".

@jhung jhung added the Question label Feb 27, 2020
@jobara jobara added question Further information is requested and removed Question labels Feb 27, 2020
@greatislander greatislander added enhancement New feature or request good first issue Good for newcomers and removed question Further information is requested labels May 5, 2021
@greatislander greatislander changed the title adding button for search Add button to search input May 5, 2021
greatislander pushed a commit that referenced this issue Apr 24, 2024
* feat: use pagefind for searching

* ci: update test command

* fix: hover styling for search results

* fix: add space between footer and load more results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants