-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: form layout improvements (resolves #75) #76
Conversation
I noticed in the referenced WebAIM article the section on aria-invalid. Which suggests that you set it when an error is present. Looking at the ARIA spec, |
@greatislander you may want to look into the support for |
I found this, @jobara — sounds like support for |
@jobara I've added |
@greatislander the thread you referenced mentioned two issues: nvaccess/nvda#8318 and FreedomScientific/standards-support#83. They are both still open. Sounds like at least some of the browsers may be exposing things correctly, and that support for JAWS is improving. |
@jobara I think given that support is not consistent across browsers/screen readers it makes sense to stick with using a combo of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! (there's no approve option on here, let me know if I have to do something else)
This PR makes a number of improvements to Looseleaf's form handling based on suggestions that emerged while working on the platform. As follows:
<legend>
<fieldsets>
<input type="submit">
and<input type="reset">
Testing
Review all variants of the following components:
As well as the combined Form layout.