Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncontrolled infinite loop #1002

Open
dacevedo12 opened this issue Jan 31, 2023 · 0 comments
Open

Uncontrolled infinite loop #1002

dacevedo12 opened this issue Jan 31, 2023 · 0 comments

Comments

@dacevedo12
Copy link
Collaborator

Using the wait_port and done_port functions from the manage-ports argument results in an uncontrolled infinite loop when the timeout is reached, printing:

Timeout while waiting for ${host}:${port} to open
Timeout while waiting for ${host}:${port} to open
Timeout while waiting for ${host}:${port} to open
...

This return doesn't seem to be working properly https://github.com/fluidattacks/makes/blob/main/src/args/manage-ports/template.sh#L51

este6an13 added a commit to este6an13/makes that referenced this issue Jul 8, 2023
Signed-off-by: Diego Quintero <diquintero@unal.edu.co>
este6an13 added a commit to este6an13/makes that referenced this issue Jul 12, 2023
- default import of `shellCommands` builtin in `makeTemplate`

Signed-off-by: Diego Quintero <diquintero@unal.edu.co>
este6an13 added a commit to este6an13/makes that referenced this issue Jul 12, 2023
- sourcing `shellCommands` into `managePorts` builtin

Signed-off-by: Diego Quintero <diquintero@unal.edu.co>
este6an13 added a commit to este6an13/makes that referenced this issue Jul 12, 2023
- sourcing `shellCommands` into `managePorts` builtin

Signed-off-by: Diego Quintero <diquintero@unal.edu.co>
este6an13 added a commit to este6an13/makes that referenced this issue Jul 13, 2023
- sourcing `shellCommands` into `managePorts` builtin

Signed-off-by: Diego Quintero <diquintero@unal.edu.co>
este6an13 added a commit to este6an13/makes that referenced this issue Jul 13, 2023
- sourcing `shellCommands` into `managePorts` builtin

Signed-off-by: Diego Quintero <diquintero@unal.edu.co>
dsalaza4 added a commit that referenced this issue Jul 13, 2023
fix(build): #1002 args manage ports fix
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Oct 9, 2023
- Fix uncontrolled infinite loop at `wait_for_tcp` function

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
acuberosatfluid added a commit that referenced this issue Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants