Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor makeNodeJsLock #1212

Closed
2 tasks done
rohaquinlop opened this issue Dec 13, 2023 · 0 comments
Closed
2 tasks done

Refactor makeNodeJsLock #1212

rohaquinlop opened this issue Dec 13, 2023 · 0 comments

Comments

@rohaquinlop
Copy link
Collaborator

rohaquinlop commented Dec 13, 2023 •
edited
Loading

Refactor makeNodeJsLock to only receive the node_js_version and the path that contains the package.json file, no other parameters will be necessaries to generate the package-lock.json file correctly. The same path that contains package.json will always contain the package-lock.json file.

  • Refactor makeNodeJsLock
  • Update the documentation

Originally posted by @rohaquinlop in #1208 (comment)
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Dec 13, 2023
@rohaquinlop
feat(build): fluidattacks#1212 upgrade makenodejslock parameters
c2aed9a 
- `makeNodeJsLock` now receives the directory that contains the
  `package.json` file instead of the `package.json` file itself.
- The `package-lock.json` file will be generated in the same directory
  that contains the `package.json` file.
- `makeNodeJsLock` now only receives two parameters: `node_js_version`
  and `package_json_dir`.
- Removed `package_lock` parameter from `makeNodeJsLock`.
- Updated `makeNodeJsLock` documentation.

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Dec 13, 2023
@rohaquinlop
feat(build): fluidattacks#1212 upgrade makenodejslock parameters
af3f4b2 
- `makeNodeJsLock` now receives the directory that contains the
  `package.json` file instead of the `package.json` file itself.
- The `package-lock.json` file will be generated in the same directory
  that contains the `package.json` file.
- `makeNodeJsLock` now only receives two parameters: `node_js_version`
  and `package_json_dir`.
- Removed `package_lock` parameter from `makeNodeJsLock`.
- Updated `makeNodeJsLock` documentation.

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Dec 14, 2023
@rohaquinlop
feat(build): fluidattacks#1212 upgrade makenodejslock parameters
550f8dd 
- `makeNodeJsLock` now receives the directory that contains the
  `package.json` file instead of the `package.json` file itself.
- The `package-lock.json` file will be generated in the same directory
  that contains the `package.json` file.
- `makeNodeJsLock` now only receives two parameters: `node_js_version`
  and `package_json_dir`.
- Removed `package_lock` parameter from `makeNodeJsLock`.
- Updated `makeNodeJsLock` documentation.

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
dsalaza4 added a commit that referenced this issue Dec 14, 2023
@dsalaza4
Merge pull request #1215 from rohaquinlop/issue-1212
fc1be2e 
feat(build): #1212 upgrade makenodejslock parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rohaquinlop