Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/homeless-shelter issue #1282

Closed
rohaquinlop opened this issue Jan 25, 2024 · 0 comments
Closed

/homeless-shelter issue #1282

rohaquinlop opened this issue Jan 25, 2024 · 0 comments
Assignees
@rohaquinlop

Comments

@rohaquinlop
Copy link
Collaborator

rohaquinlop commented Jan 25, 2024 •
edited
Loading

When updating makes-example found this issue, tried to solve it at the same repo but I think it's possible to solve this error here in the built-in.

Here you can see the logs and this is the PR with all my attempts and the issue.

Also, I don't know if it's related to this issue but found that in universe we are using pylint which is used in our built-in lintPython and we are removing /homeless-shelter, here you can see the code.
@rohaquinlop rohaquinlop self-assigned this Jan 25, 2024
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jan 26, 2024
@rohaquinlop
feat(build): fluidattacks#1282 assure purity removing dir
ea27f0d 
- Set `HOME` to a temp dir
- Remove `homeless-shelter` dir if it exists

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jan 26, 2024
@rohaquinlop
feat(build): fluidattacks#1282 assure purity removing dir
921536a 
- Set `HOME` to a temp dir
- Remove `homeless-shelter` dir if it exists

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jan 26, 2024
@rohaquinlop
feat(build): fluidattacks#1282 assure purity removing dir
fcf1ed8 
- Set `HOME` to a temp dir
- Remove `homeless-shelter` dir if it exists

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jan 26, 2024
@rohaquinlop
feat(build): fluidattacks#1282 assure purity removing dir
e7899b4 
- Set `HOME` to a temp dir
- Remove `homeless-shelter` dir if it exists
- Update mailmap

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jan 26, 2024
@rohaquinlop
feat(build): fluidattacks#1282 assure purity removing dir
28a5785 
- Set `HOME` to a temp dir
- Remove `homeless-shelter` dir if it exists
- Update mailmap

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jan 29, 2024
@rohaquinlop
feat(build): fluidattacks#1282 assure purity removing dir
4dad957 
- Set `HOME` to a temp dir
- Remove `homeless-shelter` dir if it exists
- Update mailmap

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jan 29, 2024
@rohaquinlop
feat(build): fluidattacks#1282 assure purity removing dir
b5ad1bf 
- Update mailmap
- Set `HOME` to a temp dir
- Remove `homeless-shelter` dir if it exists

Approach:
- Read the TOML file and get the packages.
- Override the `preUnpack` function to set
`HOME` to a temp dir.
- Override the `overrides` function to combine,
in case of conflict, the `overrides` that was passed
will be the one that prevails.

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jan 29, 2024
@rohaquinlop
feat(build): fluidattacks#1282 assure purity removing dir
41508c4 
- Update mailmap
- Set `HOME` to a temp dir
- Remove `homeless-shelter` dir if it exists

Approach:
- Read the TOML file and get the packages.
- Override the `preUnpack` function to set
`HOME` to a temp dir.
- Override the `overrides` function to combine,
in case of conflict, the `overrides` that was passed
will be the one that prevails.

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jan 30, 2024
@rohaquinlop
feat(build): fluidattacks#1282 assure purity removing dir
1d7681d 
- Update mailmap
- Set `HOME` to a temp dir
- Remove `homeless-shelter` dir if it exists
- Create external function to fetch all packages
names from a TOML file, including the extras

Approach:
- Read the TOML file and get the packages.
- Override the `preUnpack` function to set
`HOME` to a temp dir.
- Override the `overrides` function to combine,
in case of conflict, the `overrides` that was passed
will be the one that prevails.

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jan 31, 2024
@rohaquinlop
feat(build): fluidattacks#1282 assure purity removing dir
023b700 
- Update mailmap
- Set `HOME` to a temp dir
- Remove `homeless-shelter` dir if it exists
- Create external function to fetch all packages
names from a TOML file, including the extras

Approach:
- Read the TOML file and get the packages.
- Override the `preUnpack` function to set
`HOME` to a temp dir.
- Override the `overrides` function to combine,
in case of conflict, the `overrides` that was passed
will be the one that prevails.

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jan 31, 2024
@rohaquinlop
feat(build): fluidattacks#1282 assure purity removing dir
8e570ae 
- Update mailmap
- Set `HOME` to a temp dir
- Remove `homeless-shelter` dir if it exists
- Create external function to fetch all packages
names from a TOML file, including the extras

Approach:
- Read the TOML file and get the packages.
- Override the `preUnpack` function to set
`HOME` to a temp dir.
- Override the `overrides` function to combine,
in case of conflict, the `overrides` that was passed
will be the one that prevails.

Signed-off-by: Robin Quintero <rohaquinlop301@gmail.com>
rohaquinlop added a commit that referenced this issue Jan 31, 2024
@rohaquinlop
Merge pull request #1285 from rohaquinlop/issue-1282
b2cca5f 
feat(build): #1282 assure purity removing dir
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jan 31, 2024
@dsalaza4
refac(back): fluidattacks#1282 minor refactors
4d16206 
- Minor refactors to make-python-environment builtin
for clarity

Signed-off-by: Daniel Salazar <podany270895@gmail.com>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jan 31, 2024
@dsalaza4
refac(back): fluidattacks#1282 minor refactors
329162c 
- Minor refactors to make-python-environment builtin
for clarity

Signed-off-by: Daniel Salazar <podany270895@gmail.com>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jan 31, 2024
@dsalaza4
refac(back): fluidattacks#1282 minor refactors
472706f 
- Minor refactors to make-python-environment builtin
for clarity

Signed-off-by: Daniel Salazar <podany270895@gmail.com>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Jan 31, 2024
@dsalaza4
refac(back): fluidattacks#1282 minor refactors
ae9cf1a 
- Minor refactors to make-python-environment builtin
for clarity

Signed-off-by: Daniel Salazar <podany270895@gmail.com>
rohaquinlop added a commit that referenced this issue Jan 31, 2024
@rohaquinlop
Merge pull request #1287 from dsalaza4/main
9f93d14 
refac(back): #1282 minor refactors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohaquinlop rohaquinlop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rohaquinlop