feat(build): #944 doas make #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kamadorueda
commented
Sep 30, 2022
kamadorueda
commented
- We cannot make the container fully non-root, but we can make makes run as makes.
- Expose this feature under a feature flag, since it has a small performance hit at the beginning while chown-ing /nix and also allowing us to test this without much risk
- We cannot make the container fully non-root, but we can make makes run as makes. - Expose this feature under a feature flag, since it has a small performance hit at the beginning while chown-ing /nix and also allowing us to test this without much risk
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions bot
added a commit
that referenced
this pull request
Sep 30, 2022
feat(build): #944 doas make
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.