Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade tokio to 1.9 #253

Merged
merged 2 commits into from
Aug 3, 2021
Merged

build: upgrade tokio to 1.9 #253

merged 2 commits into from
Aug 3, 2021

Conversation

noel2004
Copy link
Member

@noel2004 noel2004 commented Aug 2, 2021

According to #224, try upgrade tokio to ^1.8 (currently locked at 1.9.0)

@noel2004
Copy link
Member Author

noel2004 commented Aug 3, 2021

After upgrading to tokio 1.9, matching engine works well with tick.ts running for ~ 1hr, and idle for ~10hrs (with several dumps have being executed), then work again with tick.ts for another minutes.

Everything seems ok ...

@noel2004 noel2004 changed the title WIP: upgrade tokio to 1.8 Upgrade tokio to 1.8 Aug 3, 2021
@noel2004
Copy link
Member Author

noel2004 commented Aug 3, 2021

It seems we do not use any prost_types::timestamp inside our code

Things go well and we should upgrade it now

@0xmountaintop 0xmountaintop changed the title Upgrade tokio to 1.8 build: upgrade tokio to 1.9 Aug 3, 2021
@0xmountaintop 0xmountaintop merged commit 092f7a9 into master Aug 3, 2021
@0xmountaintop 0xmountaintop deleted the tokio_upgrade branch August 3, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants