Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add neuropil discovery for fluidos project #130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

schwicht
Copy link

This pull request adds the neccessary components to enable the discovery of fluidos nodes and flavors across the neuropil cybersecuriyt mesh

@fracappa
Copy link
Contributor

fracappa commented Dec 12, 2024

Thanks @schwicht .

Approved but you need to regenerate helm documentation as there are errors in the pipeline build.

You can do this by issuing make docs in the project and push the modification.
Thanks

@schwicht
Copy link
Author

@fracappa done, I also added some doc strings for our configuration values

@fracappa
Copy link
Contributor

@schwicht the problem still persists.

Every time you modify the values.yaml file, you need to regenerate the docs as I said before.

Moreover, whenever you apply modifications please do not forget to squash your commits.

Thanks!

also adds np discovery roles, following file naming layout
updates readme.md with updated values.yaml for helm-docs
@schwicht
Copy link
Author

@fracappa yes, I saw it yesterday already but found no time to fix it. Now it should be better

@mtt-cc
Copy link

mtt-cc commented Dec 20, 2024

Hello @schwicht,
I tried testing the pull request but I am having some issues:

  • I am able to bootstrap to the test node at *:udp4:demo.neuropil.io:3400 with my two fluidos nodes but no KnownCluster CR is created
  • Running an infrastructure node on my local machine, I am unable to bootstrap to it. Furthermore, changing the np_bootstrap_url in values.yaml does not seem to have an effect, the default value is still used.
    img 2 -np-discovery not changing when setting values

@schwicht
Copy link
Author

Thanks for reporting the issue @mtt-cc ,
The problem with the bootstrap addres has been fixed in our gitlab repository and should work now.
For the exchange of KnownClusters we also have provided a fix to resolve high latencies. Could you try again?
Otherwise please let's setup a call to have alook together ...

@mtt-cc
Copy link

mtt-cc commented Dec 23, 2024

@schwicht I tried testing again but unfortunately I am obtaining the same result, the nodes are able to bootstrap (can confirm from https://view.neuropil.io) but I am not able to see KnownClusters.
As you suggested setting up a call would be ideal, let's sync up also with Jacopo Marino at the beginning of January
Thanks and I wish you Merry Christmas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants