Fix reference to packed field is unaligned
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Sep 30, 2022
error: reference to packed field is unaligned
--> src/codec.rs:187:35
|
187 | let payload = &event.u.start;
| ^^^^^^^^^^^^^^
|
= note: `#[deny(unaligned_references)]` on by default
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #82523 <rust-lang/rust#82523>
= note: fields of packed structs are not properly aligned, and creating a misaligned reference is undefined behavior (even if that reference is never dereferenced)
= help: copy the field contents to a local variable, or replace the reference with a raw pointer and use `read_unaligned`/`write_unaligned` (loads and stores via `*p` must be properly aligned even when using raw pointers)
haata
force-pushed
the
fix_unaligned_access
branch
from
8e6d966 to
d146f2c
Compare
StaticRocket
approved these changes
Apr 26, 2023
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
Apr 26, 2023
Add some interim patches to get this building with the latest version of cargo/rust. This is messy and will be dropped as soon as the corresponding upstream PR is accepted [1]. Why is the patch bumping the uhid-virt version? Because the version published to crates.io doesn't match the upstream package version, despite the actual contents of the crate being the same. Feel free to verify this [2]. [1] flukejones/uhid-virt#4 [2] https://static.crates.io/crates/uhid-virt/uhid-virt-0.0.5.crate Signed-off-by: StaticRocket <35777938+StaticRocket@users.noreply.github.com>
|
@flukejones , heads up, this will become relevant to your prioritized users soon [1]. Also, the package version captured in this repo does not match the package version published on crates.io [2]. [1] https://doc.rust-lang.org/error_codes/E0793.html |
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
Apr 26, 2023
Relevant uhid-virt PR got merged[1]. Drop interim patches. This reverts commit aca6f4c. [1] flukejones/uhid-virt#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error: reference to packed field is unaligned
--> src/codec.rs:187:35
|
187 | let payload = &event.u.start;
| ^^^^^^^^^^^^^^
|
= note:
#[deny(unaligned_references)]on by default= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #82523 rust-lang/rust#82523
= note: fields of packed structs are not properly aligned, and creating a misaligned reference is undefined behavior (even if that reference is never dereferenced)
= help: copy the field contents to a local variable, or replace the reference with a raw pointer and use
read_unaligned/write_unaligned(loads and stores via*pmust be properly aligned even when using raw pointers)