FC-1437: fix/query limit #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cap10morgan
approved these changes
Oct 13, 2022
| (vec (take limit sorted))))) | ||
| (into [] | ||
| (comp (drop offset) | ||
| (take limit)) |
There was a problem hiding this comment.
Boy these transducer comps always look backwards to me. But because it looks backwards, it must be right! ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously queries including
orderByclauses that were executed with the "simple subject crawl" strategy applied the offset before ordering but applied the limit after, causing them to be applied out of order. This patch applies both operations post ordering and ensures that the limit is applied after the offset.