Introduce tools.build #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminates redundant version string in deps.edn and allows us to set some additional params in the generated pom.xml in the JAR file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates redundant version string in deps.edn and allows us to set some additional params in the generated pom.xml in the JAR file (like the
scmparams; FC-1213).This doesn't attempt to be a maximalist tools.build conversion, but instead just to introduce it where its sweet spot overlaps with where it can do the most good.
I don't think this steps on the shadow-cljs.edn conversion too much in the
feature/jldbranch, but let me know if you'd like to merge that before this (or even target that branch with this change).