Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ClassCastException in simple-subject-crawl #274

Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix ClassCastException in simple-subject-crawl #274

merged 1 commit into from
Nov 30, 2022

Conversation

mpoffald
Copy link
Contributor

Closes #269

@bplatz
Copy link
Contributor

bplatz commented Nov 30, 2022

For posterity, I see this breakage originated with me allowing variable values for p, where previously they had always been required to be defined. The SSC logic assumed they were static values.

Great work!

@mpoffald mpoffald merged commit 8fde3c7 into main Nov 30, 2022
@mpoffald mpoffald deleted the fix/simple-subject-crawl-error branch November 30, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bplatz bplatz bplatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some queries that use simple-subject-crawl strategy throw an error
2 participants
@mpoffald @bplatz