Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code appears to create new flakes for
@type
values (classes) when being read from commits.To my knowledge with the latest SID changes, this isn't needed and isn't done with initial transactions. At one point we did need a flake for every IRI, which is what I assume this was put in for.
I believe this would have the effect of a different db state for the same data when originally transacted vs read from commit files - as the latter would include flakes for every class, and the former would not.
After removing this code, all tests pass - but definitely want more eyeballs in case I'm missing something.
For a large commit, this code does a decent amount of work, so will help performance by removing it as well.