Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various feedback #335

Closed
gilthonweapps opened this issue Jun 19, 2020 · 6 comments
Closed

Various feedback #335

gilthonweapps opened this issue Jun 19, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@gilthonweapps
Copy link

Hi,

First, thanks for that great plugin! It is very good and helps me a lot in my app.

I have several feedbacks/questions concerning the plugin:

  • How can we have a translated list of countries for country picker? Obviously, not all apps are in English.
  • I need to tap twice on the phone picker to have the focus and if the field is empty, the flag will only appear after the second tap.
  • It would be nice to be able to start typing +XXX and have the country automatically selected based on the prefix. The field should also use a mask to format the number, e.g. +1 (123) 555-1234. If you use libphonenumber, you should be able to do all that.
  • When using FormBuilderRadioGroup, it is not possible to use FormBuilderFieldOption with value and child as only the value is displayed, not the child.
  • When the form is in readonly, it should be nice to hide all the clear buttons (e.g. date picker) and dropdown V icons.

Regards :)

@danvick
Copy link
Collaborator

danvick commented Jun 19, 2020

Hi @gilthonweapps,
I'm glad you're finding this package useful and thanks for your contribution through your feedback.

First of all, I'd like to let you know that this package makes use of other packages some of which may come with some issues of their own. Your suggestions 1, 4, and 5 fall into such.
We've had to raised issues or submit PRs to these repos just to solve such kinds of issues and other times maintain our own copy of such widgets so that we could make changes fast - which is quite inefficient.

As for issues 2 and 3 we'll consider having these improvements done - especially 2 which seems to be a bug of some kind.

Lastly, as a suggestion for the future kindly open different issues separately so that their progress could be tracked easily.

@fer-ri
Copy link
Contributor

fer-ri commented Jun 23, 2020

Just came here because the same issue with FormBuilderRadioGroup is not able to set label and value independently. After digging the source code, confirmed, the issue is within another package.

Especially this line

https://github.com/TercyoStorck/group_radio_button/blob/master/lib/src/radio_group.dart#L43

@danvick
Copy link
Collaborator

danvick commented Jun 27, 2020

I'm thinking, for this specific issue, we may be forced to make a copy of the widget and customize it to our satisfaction.

@NengSyle007
Copy link

Hi,

First, thanks for that great plugin! Yes, I want to this plugin have input mask for FormTextField and hope see it on next version.

@deandreamatias deandreamatias added the enhancement New feature or request label Jun 10, 2022
@deandreamatias
Copy link
Collaborator

Hi @gilthonweapps!
Do you can review if still needed this suggestions?
If yes, please open separated issues for each of ones.
Thanks

@deandreamatias deandreamatias added the awaiting author response Waiting for author of issue to respond with more info label Jun 13, 2022
@deandreamatias
Copy link
Collaborator

Due to lack of response, I will close this issue.
If the bug still exists, feel free to open a new separated issues

@deandreamatias deandreamatias removed the awaiting author response Waiting for author of issue to respond with more info label Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants